Skip to content

Adopt the Dependabot changelog 'draft trick'#4148

Merged
ppkarwasz merged 1 commit into
2.xfrom
fix/2.x/apply-draft-trick
Jun 18, 2026
Merged

Adopt the Dependabot changelog 'draft trick'#4148
ppkarwasz merged 1 commit into
2.xfrom
fix/2.x/apply-draft-trick

Conversation

@ppkarwasz

Copy link
Copy Markdown
Member

Applies the consumer-side changes from apache/logging-parent#476 so this repository works with the new Dependabot changelog "draft trick".

Pushes made with GITHUB_TOKEN do not retrigger workflows (GitHub anti-recursion rule), so the changelog commit cannot re-run the required checks on its own. Instead of relying on a privileged PAT, the reusable workflow now appends the changelog commit and parks the PR in draft mode; a maintainer clicks Ready for review and enables Auto-merge to complete the merge.

Changes

  • build.yaml and codeql-analysis.yaml: subscribe pull_request to explicit types including ready_for_review, so the required checks re-run when a Dependabot PR is taken out of draft.
  • process-dependabot.yaml: drop the RECURSIVE_TOKEN (DEPENDABOT_TOKEN) PAT secret, which is no longer needed, and update the permission comments to reflect the draft-based flow.

The reusable-workflow references are left at the moving @gha/v0 tag, which picks up the draft-trick behavior automatically.

Warning

Due to the breaking changes in gha/v0, Dependabot PR will not work, unless this is merged first.

Applies the consumer-side changes from logging-parent PR #476:

* `build.yaml` and `codeql-analysis.yaml` now subscribe to the
  `ready_for_review` pull request type, so required checks re-run when a
  Dependabot PR is taken out of draft.
* `process-dependabot.yaml` drops the `RECURSIVE_TOKEN` PAT secret, which
  is no longer needed now that the reusable workflow parks the PR in
  draft mode instead of pushing with a privileged token.

Assisted-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@ppkarwasz ppkarwasz merged commit c588dd5 into 2.x Jun 18, 2026
10 checks passed
@ppkarwasz ppkarwasz deleted the fix/2.x/apply-draft-trick branch June 18, 2026 08:24
@github-project-automation github-project-automation Bot moved this from Approved to Merged in Log4j pull request tracker Jun 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants