[SERVER] Add Kubernetes engine Pod discovery latency metric - #7722
Open
ruanwenjun wants to merge 3 commits into
Open
[SERVER] Add Kubernetes engine Pod discovery latency metric#7722ruanwenjun wants to merge 3 commits into
ruanwenjun wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
A Spark engine Pod can already exist in Kubernetes while Kyuubi has not yet received its informer event. This delay can contribute to an engine submission timeout, but the existing engine startup metric only covers engines that register successfully.
Add
kyuubi.engine.kubernetes.pod.discovery.latency, a histogram in milliseconds from Pod creation to entry into the informer ADD callback. Each ADD for a Spark engine Pod records a sample, including initial listing and repeated ADD events. UPDATE and DELETE events do not record samples. Missing, malformed, or future creation timestamps are skipped without preventing Pod event handling.How was this patch tested?
Validated with JDK 17.
dev/reformatran without the optional Python formatter (no Python files changed).Added tests in
KubernetesApplicationOperationSuitefor ADD latency, repeated ADD events, first UPDATE and DELETE exclusion, invalid timestamps, continued terminal-state handling, and non-engine Pods, without a Kubernetes cluster. All 8 tests passed.Was this patch assisted by generative AI tooling?
Assisted-by: Codex (GPT-6)