Repository navigation
Conversation
* Fix queued IoTConsensus writes during shutdown * Test queued IoTConsensus writes across storage shutdown * Reproduce WAL checkpoint loss from writes after shutdown * Fence IoTConsensus applies before storage shutdown (cherry picked from commit 532d6c1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Queued IoTConsensus requests can pass the RPC read-only check before shutdown and apply after storage or WAL has stopped, reopening processors and WAL nodes. This backport closes write admission and drains admitted writes, including their WAL separators, before the final flush and storage shutdown.
Cherry-picks:
Adaptation for dev/1.3
DataRegion.insertLockfor admission and WAL separators, keeping memory backpressure and retry waits outside the lock. Apply the same fencing to tree deletions, which already hold the outer visitor lock in 1.3.pipe.it.autocreate.IoTDBPipeClusterIT. Table-model code and tests do not apply to 1.3.Validation
mvn -B -nsu test -pl iotdb-core/datanode -am -Dtest=IoTConsensusServerImplTest,IoTConsensusShutdownTest,DataRegionStateMachineTest,DataRegionTest -Dsurefire.failIfNoSpecifiedTests=false -DfailIfNoTests=false -DforkCount=1.BUILD SUCCESS; 49 tests passed and 1 existing DataRegion test was skipped. The configured Maven test executions both passed.This PR has: