Repository navigation
Conversation
jt2594838
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing the last consumer currently deletes its group's checkpoints even when the topic has
retain.progress.after.unsubscribe=true. Recreating the group can then start at the WAL tail and skip data written while the group was offline. A delayed asynchronous queue close can also recreate detached WAL retention after retention was disabled, the topic was dropped, or a replacement queue was registered.This change preserves configured checkpoints and the empty group's incarnation and SQL dialect on ConfigNode and DataNode, so resubscription can resume correctly. Empty table groups encode their dialect using a negative empty-consumer count, preserving the existing serialized field boundaries. Disabling retention or dropping the topic still clears retained progress and prunes empty ConfigNode groups once no checkpoints remain.
WAL retention registration now tracks the owning queue. Delayed closes unregister the old queue but cannot restore a canceled or superseded detached registration.
Validation:
test-compile -DskipTests -Dxml-format.skip=truepassed (Chinese with-P with-zh-locale).IoTDBConsensusSubscriptionBasicTableIT#testLastConsumerCloseRetainsProgresspassed on 1 ConfigNode + 1 DataNode with IoTConsensus, covering both direct close and unsubscribe-then-close, followed by consumption of offline writes without seek. Subscription was enabled only in temporary test artifacts because the community edition disables it at compile time.git diff --checkpassed.