Repository navigation
[To dev/1.3] [Bugfix] Reclaim RPC buffers by evicting idle clients (#18853) - #18882
Merged
Merged
Conversation
* [Bugfix] Reclaim idle RPC buffers when the shared pool is exhausted * [Bugfix] Evict idle RPC clients to release buffers (cherry picked from commit 1b290ae)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport #18853 (commit 1b290ae) to
dev/1.3.The default eviction sweep checks only three idle clients, which can retain expired connections and their RPC buffers for hours in large pools. Check all idle clients in each sweep and reduce the default eviction interval from one minute to 30 seconds.
dev/1.3does not have the RPC buffer memory accounting APIs used by the original tests. Adapt the regression tests to its existing transport APIs, covering eviction across nodes, background eviction, preservation of borrowed and unexpired clients, and closure of both ends of a connection with compression enabled and disabled.Validation
mvn spotless:apply -pl iotdb-core/node-commonsmvn "-Ddevelocity.off=true" -pl iotdb-core/node-commons -am "-Dtest=ClientPoolIdleEvictionTest" "-Dsurefire.failIfNoSpecifiedTests=false" test— all 21 reactor modules succeeded; 8 tests passed, with no failures or skips.git diff --check