Repository navigation
[Fix] Preserve table insert errors for rejected fields - #18880
Conversation
Caideyipi
left a comment
There was a problem hiding this comment.
Reviewed commit 916ecf4. No blocking issues found in grouped Tablet exception preservation, fully rejected FIELD handling, or the Pipe heartbeat test fixture update.
Validation: compiled the changed classes against local build artifacts and ran SessionCacheLeaderTest (12), AnalyzeUtilsTest (7), and PipeMemoryManagerResizeTest (11) via JUnitCore; all 30 tests passed. Full integration tests were not run locally.
916ecf4 to
8d57461
Compare
|
Thanks for the review. Since commit 916ecf4, the branch has also added the table-model case where every supplied FIELD is rejected: the metadata error is preserved, and the timestamp row is still written, including when no TAG survives validation. This is covered by commit 9a7fb10. I ran the focused |
Description
Verification
mvn spotless:check -pl iotdb-core/datanode,integration-test -P with-integration-tests -qandgit diff --check— passed.mvn verify -DskipUTs -Dit.test=IoTDBInsertTableIT#testRejectedOnlyFieldStillWritesTime -DfailIfNoTests=false -Dfailsafe.failIfNoSpecifiedTests=false -pl integration-test -am -PTableSimpleIT -P with-integration-tests -q— passed (1 ConfigNode, 1 DataNode).-PTableClusterIT— passed (1 ConfigNode, 3 DataNodes). It checks field error reporting, time-row visibility with and without TAGs, and visibility after flush.mvn test -pl iotdb-core/datanode -am -Dtest=AnalyzeUtilsTest,TsFilePlanRedoerTest#testRedoRelationalInsertWithoutFieldValues,InsertNodeIsMeasurementFailedTest -Dsurefire.failIfNoSpecifiedTests=false -q— 7, 1, and 23 tests passed. The WAL test serializes, deserializes, and replays zero-measurement row and tablet nodes.mvn test-compile -P with-zh-locale -DskipTests -q— full reactor passed. The default-locale reactor build also passed as part of targeted IT verification.Review
timeand no originally supplied FIELD remains separate from partial insertion after FIELD validation failure.