Skip to content

[To dev/1.3] Fix flaky space quota result polling in cluster tests #18867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Caideyipi wants to merge 1 commit into
base: dev/1.3
Choose a base branch
from
Open

[To dev/1.3] Fix flaky space quota result polling in cluster tests #18867

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions integration-test/src/test/java/org/apache/iotdb/db/it/quotas/IoTDBSpaceQuotaIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
import org.apache.iotdb.it.framework.IoTDBTestRunner;
import org.apache.iotdb.itbase.category.ClusterIT;
import org.apache.iotdb.itbase.category.LocalStandaloneIT;
import org.apache.iotdb.itbase.exception.InconsistentDataException;

import org.awaitility.Awaitility;
import org.junit.After;
Expand Down Expand Up @@ -515,6 +516,10 @@ private void validateResultSetEventually(Statement statement, String sql, String
.pollDelay(0, TimeUnit.MILLISECONDS)
.pollInterval(1, TimeUnit.SECONDS)
.atMost(30, TimeUnit.SECONDS)
// Cluster queries compare results from all DataNodes. Space quota usage is refreshed
// asynchronously by heartbeats, so the comparison can observe different snapshots while
// the usage converges. Awaitility does not retry runtime exceptions by default.
.ignoreExceptionsMatching(e -> e instanceof InconsistentDataException)
.untilAsserted(
() -> {
try {
Expand Down
Loading