Repository navigation
[To dev/1.3] [Pipe] Wake parser workers when admission is available - #18865
Merged
Merged
Conversation
* Fix pipe parser admission wake-ups * Avoid reflective test dependency (cherry picked from commit aec1ad6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When TsFile parser admission becomes available, processor workers can remain asleep until their next polling interval, delaying pipes behind the fair admission queue. Wake the relevant worker immediately and retain notifications that arrive before the worker begins its idle wait.
Backport of #18843, cherry-picked from
aec1ad6139cb4dd1450725f53418cf40c26efb4etodev/1.3.PipeMemoryManagerconflicts, and retain the existing disk-I/O counter when resolvingPipeResourceMetricsconflicts.Validation
mvn -B -nsu spotless:apply -pl iotdb-core/datanode,iotdb-core/node-commons— passed; no formatting changes.mvn -B -nsu test-compile -DskipTests— full reactor passed.mvn -B -nsu test-compile -P with-zh-locale -DskipTests— full reactor passed withMAVEN_OPTS="-Xmx2048m -XX:MaxMetaspaceSize=512m"; the initial uncapped attempt exhausted local native memory after DataNode compiled successfully.mvn -B -nsu test -pl iotdb-core/datanode -am -Dtest=PipeProcessorSubtaskExecutionGuardTest,PipeProcessorSubtaskWorkerTest,PipeMemoryManagerTest -Dsurefire.failIfNoSpecifiedTests=false -DfailIfNoTests=false— all 18 tests passed, with no failures, errors, or skipped tests.git diff --check— passed.Checklist