Repository navigation
Conversation
jt2594838
approved these changes
Oct 10, 2026
jt2594838
deleted the
fix/subscription-release-exhausted-tsfile-parser
branch
October 10, 2026 11:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a subscription tablet batch contains multiple historical TsFiles from the same pipe region, exhausting one file leaves its parser reservation held until the response is ACKed. With the per-pipe-region parser limit set to 1, opening the next file in that batch repeatedly waits for parser memory and times out, delaying snapshot delivery.
Close the current TsFile event as soon as its tablet iterator is exhausted, including files filtered to zero tablets. Keep the parsed tablet event references in the iteration snapshot until ACK or cleanup, so releasing the parser does not release tablets still needed by the response.
Validation
git diff --checkpassed.master, compilation and tests were not rerun locally. CI validation and the repeated snapshot cluster scenario remain pending.This PR has:
Key changed/added classes:
SubscriptionPipeTabletEventBatchSubscriptionPipeTabletEventBatchTest