Repository navigation
Remove some printed errMsg when stop DN - #18799
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #18799 +/- ##
============================================
+ Coverage 45.83% 45.85% +0.01%
Complexity 712 712
============================================
Files 5498 5498
Lines 397501 397505 +4
Branches 51737 51741 +4
============================================
+ Hits 182200 182278 +78
+ Misses 215301 215227 -74 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Signed-off-by: Weihao Li <18110526956@163.com> # Conflicts: # iotdb-core/datanode/src/main/java/org/apache/iotdb/db/service/DataNodeShutdownHook.java
JackieTien97
approved these changes
Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
During DataNode shutdown, an active query may be interrupted and transition to FAILED. Its resources can then be cleaned up concurrently through two paths:
Path 1: FragmentInstance state-change listener
→ Close drivers
→ Force-deregister the FI from the memory pool
Path 2: DriverScheduler abort
→ forceDeregisterFragmentInstance
→ SourceHandle.abort
→ MemoryPool.free
If Path 1 removes the FI memory registration firstly, it will throw MemoryLeakException because some PlanNode memory reservations are still non-zero.
Path 2 may subsequently attempt to release memory retained by a SourceHandle. Since the Query/FI registration has already been removed, MemoryPool.free() throws IllegalArgumentException:
RelatedMemoryReserved can't be null when freeing memory.Fix
Checks isStopping before logging query cleanup errors in. And move setStopping before stop ExternalRPCService to ensure Stopping is set before query failed.