Repository navigation
allowlist-approval: re-run the stale check after an approval - #1426
Merged
Merged
Conversation
Approving an allow-list PR turns the review-triggered approval run green, but the ruleset keeps blocking on the earlier failed run from the pull_request event. A workflow_run job now re-runs that failed run once a review makes the check pass, so an approved PR becomes mergeable without a manual re-run. Generated-by: Claude Opus 5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
approvalrun green, but theRequired checksruleset keeps blocking on the earlier failed run from thepull_requestevent, so approved allow-list PRs stayBLOCKEDuntil someone re-runs that run by hand.allowlist_approval_rerun.yml(workflow_run, since a review on a fork PR only has a read-only token) re-runs that failed run once a review makes the check pass. It runs from the default branch, reads only the head SHA, and re-runs only the latestpull_requestrun of the check (scripts/rerun_allowlist_approval.py).approvalgate.Test plan
uv run pytest scripts/: new tests forrun_to_rerunand SHA validation pass.prek run --all-filesandzizmorare clean (dangerous-triggersis suppressed inline, with the reason).BLOCKED; re-running each failedpull_requestrun by hand made all of themCLEAN, which is what this job automates.🤖 Generated with Claude Code