Skip to content

IGNITE-27926 Implement Raft group destruction in Segstore#7958

Merged
sashapolo merged 4 commits intoapache:mainfrom
gridgain:ignite-27926
Apr 16, 2026
Merged

IGNITE-27926 Implement Raft group destruction in Segstore#7958
sashapolo merged 4 commits intoapache:mainfrom
gridgain:ignite-27926

Conversation

@sashapolo
Copy link
Copy Markdown
Contributor

https://issues.apache.org/jira/browse/IGNITE-27926

Thank you for submitting the pull request.

To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:

The Review Checklist

  • Formal criteria: TC status, codestyle, mandatory documentation. Also make sure to complete the following:
    - There is a single JIRA ticket related to the pull request.
    - The web-link to the pull request is attached to the JIRA ticket.
    - The JIRA ticket has the Patch Available state.
    - The description of the JIRA ticket explains WHAT was made, WHY and HOW.
    - The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
  • Design: new code conforms with the design principles of the components it is added to.
  • Patch quality: patch cannot be split into smaller pieces, its size must be reasonable.
  • Code quality: code is clean and readable, necessary developer documentation is added if needed.
  • Tests code quality: test set covers positive/negative scenarios, happy/edge cases. Tests are effective in terms of execution time and resources.

Notes

Copilot AI review requested due to automatic review settings April 8, 2026 16:06
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Implements Raft group destruction support for segstore-backed Raft logs so that per-group log data can be logically tombstoned and later reclaimed by the segment GC.

Changes:

  • Add SegmentFileManager.destroyGroup(...) which writes a destroy tombstone via a reset marker.
  • Teach IndexFileManager to drop in-memory index metadata for a group when the destroy tombstone is checkpointed.
  • Add/extend tests to validate GC behavior and index-meta cleanup after group destroy.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
modules/raft/src/main/java/org/apache/ignite/internal/raft/storage/segstore/SegmentLogStorageManager.java Switch group destruction to fileManager.destroyGroup(...) instead of reset(...).
modules/raft/src/main/java/org/apache/ignite/internal/raft/storage/segstore/SegmentFileManager.java Introduce GROUP_DESTROY_LOG_INDEX sentinel and destroyGroup(...) wrapper over reset(...).
modules/raft/src/main/java/org/apache/ignite/internal/raft/storage/segstore/IndexFileManager.java Remove per-group in-memory index metadata when a destroy sentinel is observed during checkpoint.
modules/raft/src/test/java/org/apache/ignite/internal/raft/storage/segstore/RaftLogGarbageCollectorTest.java Add GC-focused tests covering segment/index file reclamation after group destruction.
modules/raft/src/test/java/org/apache/ignite/internal/raft/storage/segstore/IndexFileManagerTest.java Add tests validating that destroy tombstones clear group index metadata on checkpoint.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor

@Phillippko Phillippko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sashapolo sashapolo merged commit cce3dca into apache:main Apr 16, 2026
3 of 5 checks passed
@sashapolo sashapolo deleted the ignite-27926 branch April 16, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants