IGNITE-27926 Implement Raft group destruction in Segstore#7958
Merged
sashapolo merged 4 commits intoapache:mainfrom Apr 16, 2026
Merged
IGNITE-27926 Implement Raft group destruction in Segstore#7958sashapolo merged 4 commits intoapache:mainfrom
sashapolo merged 4 commits intoapache:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Implements Raft group destruction support for segstore-backed Raft logs so that per-group log data can be logically tombstoned and later reclaimed by the segment GC.
Changes:
- Add
SegmentFileManager.destroyGroup(...)which writes a destroy tombstone via a reset marker. - Teach
IndexFileManagerto drop in-memory index metadata for a group when the destroy tombstone is checkpointed. - Add/extend tests to validate GC behavior and index-meta cleanup after group destroy.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| modules/raft/src/main/java/org/apache/ignite/internal/raft/storage/segstore/SegmentLogStorageManager.java | Switch group destruction to fileManager.destroyGroup(...) instead of reset(...). |
| modules/raft/src/main/java/org/apache/ignite/internal/raft/storage/segstore/SegmentFileManager.java | Introduce GROUP_DESTROY_LOG_INDEX sentinel and destroyGroup(...) wrapper over reset(...). |
| modules/raft/src/main/java/org/apache/ignite/internal/raft/storage/segstore/IndexFileManager.java | Remove per-group in-memory index metadata when a destroy sentinel is observed during checkpoint. |
| modules/raft/src/test/java/org/apache/ignite/internal/raft/storage/segstore/RaftLogGarbageCollectorTest.java | Add GC-focused tests covering segment/index file reclamation after group destruction. |
| modules/raft/src/test/java/org/apache/ignite/internal/raft/storage/segstore/IndexFileManagerTest.java | Add tests validating that destroy tombstones clear group index metadata on checkpoint. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-27926
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:
The Review Checklist
- There is a single JIRA ticket related to the pull request.
- The web-link to the pull request is attached to the JIRA ticket.
- The JIRA ticket has the Patch Available state.
- The description of the JIRA ticket explains WHAT was made, WHY and HOW.
- The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
Notes