Conversation
Streams Iggy messages into BigQuery through the Storage Write API _default stream with Arrow-encoded rows. Supports mapped and raw modes, Iggy metadata columns, per-row rejection with offset logging, request splitting below the AppendRows limit, and retries for transient gRPC failures. Verified against a live BigQuery table; CI coverage uses an in-process fake of tables.get and BigQueryWrite. Closes #4393
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #4394 +/- ##
============================================
- Coverage 87.96% 87.86% -0.11%
+ Complexity 1579 1578 -1
============================================
Files 1290 1296 +6
Lines 230145 232191 +2046
Branches 193480 195529 +2049
============================================
+ Hits 202440 204007 +1567
- Misses 22980 23367 +387
- Partials 4725 4817 +92
🚀 New features to boost your workflow:
|
Contributor
|
/skill team-review-slim |
There was a problem hiding this comment.
Summary: The review found a rustdoc link error that fails the doctest job, a token error classified as permanent so open() never retries it, a missing integration test, and hot-path encoding costs. Two simplifications cover a hand-rolled hex helper and two Option fields that always move together.
Counts: critical 0, warning 5, nit 2, simplification 2
This review was generated by Claude Code 2.1.284 on deepseek-flash[1m]. Review the output before you act on it.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR address?
Closes #4393
Rationale
Streams Iggy messages into BigQuery through the Storage Write API _default stream with Arrow-encoded rows. Supports mapped and raw modes, Iggy metadata columns, per-row rejection with offset logging, request splitting below the AppendRows limit, and retries for transient gRPC failures. Verified against a live BigQuery table; CI coverage uses an in-process fake of tables.get and BigQueryWrite.
What changed?
New sink connector under /core/connectors/sinks
Local Execution
AI Usage