Repository navigation
Core: Send snapshot events and commit reports after a transaction commits - #18591
Open
binarybrain-009 wants to merge 1 commit into
Open
binarybrain-009 wants to merge 1 commit into
binarybrain-009 wants to merge 1 commit into
Conversation
…mits Snapshot producers in a transaction notified listeners and reported commit metrics when their change was only staged, so events were sent for snapshots that might never be committed, and sent again when a retried transaction re-applied its updates. The transaction now sends each producer's latest event once the transaction has committed. Closes apache#7278
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Snapshot producers created by a transaction notified listeners and reported commit metrics from their own
commit(), which only stages the change. ACreateSnapshotEventandCommitReportwere therefore sent for snapshots that might never be committed, and sent again each time a retried transaction re-applied its updates. Each producer now keeps the event from its latest staged commit, andcommitTransaction()sends them once the table commit succeeds. Changes committed through the multi-tableTableCommitAPI never callcommitTransaction(), so they no longer send these notifications.CatalogTests#testCatalogWithCustomMetricsReportercounted reports from uncommitted create/replace transactions, so it now commits them first.Closes #7278
Test plan: an uncommitted or failed transaction sends no event and a committed one does; a retried transaction sends a single report with the committed sequence number; create/replace transactions report only after commit in every catalog.
AI Disclosure