Repository navigation
AWS: Apply Glue and KMS endpoint overrides in AssumeRoleAwsClientFactory - #18586
Open
yusufyildiz34 wants to merge 1 commit into
Open
yusufyildiz34 wants to merge 1 commit into
yusufyildiz34 wants to merge 1 commit into
Conversation
AssumeRoleAwsClientFactory built Glue and KMS clients without the glue.endpoint and kms.endpoint overrides, and LakeFormationAwsClientFactory did the same for KMS clients of registered tables, so these clients always used the default AWS endpoints. Closes apache#17047 Co-authored-by: Eunbin Son <thswlsqls@naver.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AssumeRoleAwsClientFactorybuilds its Glue and KMS clients without applyingglue.endpointandkms.endpoint, while its DynamoDB client andDefaultAwsClientFactoryapply them, so assume-role users can't point Glue or KMS at a custom endpoint.LakeFormationAwsClientFactoryhas the same gap for the KMS client it builds for registered tables. This applies the existingAwsPropertiesendpoint configurations in those three builders. Catalogs that already set these properties with an assume-role factory will now use them. It continues #17049, which the stale bot closed without review.Closes #17047
Test plan: three
TestAwsClientFactoriescases check the endpoint override on the assume-role Glue and KMS clients and on the Lake Formation KMS client for a registered table; all fail on main and pass with this change.AI Disclosure