Skip to content

Hive: Write format-version to HMS table parameters #18534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pvary merged 2 commits into from
Oct 20, 2026
+50 −0
Merged

Hive: Write format-version to HMS table parameters #18534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d01fa1e
Hive: Write format-version to HMS table parameters
anuragmantri Oct 13, 2026
5d6be89
Hive: Run format-version parameter test across all format versions
anuragmantri Oct 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions hive-metastore/src/main/java/org/apache/iceberg/hive/HMSTablePropertyHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ public static void updateHmsTableForIcebergTable(
maxHiveTablePropertySize);
setStorageHandler(parameters, hiveEngineEnabled);
setMetadataHash(metadata, parameters);
parameters.put(TableProperties.FORMAT_VERSION, String.valueOf(metadata.formatVersion()));

@pvary pvary Oct 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't do this in the setCommonParameters?

@anuragmantri anuragmantri Oct 20, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setCommonParameters is also used for views, and a view has its own format version in ViewMetadata. Writing it there would put a view version under the same key as a table version. I kept it in updateHmsTableForIcebergTable so only tables get it. If you would rather have it in the shared method, I can pass the format version in and use a different key for views. What do you prefer?


// Set the basic statistics
if (summary.get(SnapshotSummary.TOTAL_DATA_FILES_PROP) != null) {
Expand Down
49 changes: 49 additions & 0 deletions hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveCatalog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@
import org.junit.jupiter.api.extension.RegisterExtension;
import org.junit.jupiter.api.io.TempDir;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.FieldSource;
import org.junit.jupiter.params.provider.ValueSource;

/**
Expand Down Expand Up @@ -994,6 +995,54 @@ public void testUUIDinTableProperties() throws Exception {
}
}

@ParameterizedTest
@FieldSource("org.apache.iceberg.TestHelpers#ALL_VERSIONS")
void formatVersionInTableParametersOnCreate(int formatVersion) throws Exception {
Schema schema = getTestSchema();
TableIdentifier tableIdentifier = TableIdentifier.of(DB_NAME, "tbl");
String location = temp.resolve("tbl").toUri().toString();

try {
catalog
.buildTable(tableIdentifier, schema)
.withLocation(location)
.withProperty(TableProperties.FORMAT_VERSION, String.valueOf(formatVersion))
.create();

assertThat(hmsTableParameters())
.containsEntry(TableProperties.FORMAT_VERSION, String.valueOf(formatVersion));
} finally {
catalog.dropTable(tableIdentifier);
}
}

@Test
void formatVersionInTableParametersOnUpgrade() throws Exception {
Schema schema = getTestSchema();
TableIdentifier tableIdentifier = TableIdentifier.of(DB_NAME, "tbl");
String location = temp.resolve("tbl").toString();
int upgradedFormatVersion = 3;

try {
catalog
.buildTable(tableIdentifier, schema)
.withLocation(location)
.withProperty(TableProperties.FORMAT_VERSION, "2")
.create();

catalog
.loadTable(tableIdentifier)
.updateProperties()
.set(TableProperties.FORMAT_VERSION, String.valueOf(upgradedFormatVersion))
.commit();

assertThat(hmsTableParameters())
.containsEntry(TableProperties.FORMAT_VERSION, String.valueOf(upgradedFormatVersion));
} finally {
catalog.dropTable(tableIdentifier);
}
}

@Test
public void testSnapshotStatsTableProperties() throws Exception {
Schema schema = getTestSchema();
Expand Down
Loading