Repository navigation
Conversation
…osition deletes Rewriting position delete files and then expiring the snapshot that added the old ones leaves DELETED entries in the manifest whose files no longer exist. rewrite_table_path used to try to rewrite those files and fail with a NotFoundException. That was fixed by apache#15470, but nothing covered this case, so add a regression test.
Contributor
Author
|
@amogh-jahagirdar @szehon-ho could you take a look when you have a chance? This adds a regression test for the #16662 scenario, which #15470 fixed. cc @leeyam24 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scenario in #16662 (rewrite position delete files, expire the snapshot that added the old ones, then run
rewrite_table_path) no longer fails on main. #15470 changed the action to collect position delete files with aManifestReader, which returns only live entries, so DELETED entries whose files were removed by expiration are no longer opened. Nothing in the test suite covered this case, so this adds a regression test. Run against the commit before #15470, the same test fails withNotFoundException: File does not exist: .../old-deletes.parquet; on main it passes. The core-only fix proposed in #16669 is no longer needed for this path.Test plan:
positionDeletesRewrittenAndExpired(v2) checks that the expired delete file is gone, that only the live delete file is rewritten, and that the copied target table reads the expected row.Closes #16662