Repository navigation
Conversation
akashrn5
changed the title
akashrn5
changed the title
Author
nastra
reviewed
Oct 12, 2026
nastra
reviewed
Oct 12, 2026
nastra
reviewed
Oct 12, 2026
Author
|
@nastra can you please have a look at the changes and help to review and merge? i have handled all the review comments |
nastra
reviewed
Oct 19, 2026
| File testFile = File.createTempFile("junit", null, temp.toFile()); | ||
| assertThat(testFile.delete()).as("Delete should succeed").isTrue(); | ||
|
|
||
| FileAppender<Record> writer = |
Contributor
There was a problem hiding this comment.
can we use a try-finally block here and maybe try and write a record?
Author
There was a problem hiding this comment.
i used try with resource and created an actual record for the test, please review
nastra
changed the title
nastra
approved these changes
Oct 19, 2026
Contributor
|
@akashrn5 can you please check whether we have the same issue with Flink's ORC reader/writer? |
Author
uros-b
approved these changes
Oct 19, 2026
Member
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #18386
Summary
Writing a
VARIANTcolumn to a v3 table whose write format is ORC fails with aNullPointerExceptionfrom insideSparkOrcWriter, instead of theUnsupportedOperationException("Variant is not supported")thatOrcSchemaWithTypeVisitoralready defines for this case.