Repository navigation
Conversation
Generated-by: Codex
70c3d83 to
7918ffd
Compare
| git status --short --branch | ||
| find spark -maxdepth 1 -type d -name 'v*' -print | ||
| rg -n 'knownSparkVersions|defaultSparkVersions|sparkVersions|spark[0-9]+' \ | ||
| gradle.properties gradle settings.gradle build.gradle spark jmh.gradle .github dev site |
There was a problem hiding this comment.
This rg pattern doesn't match sparkScalaVersions, the map inside project(':iceberg-bom') in root build.gradle that controls which Scala variants of a Spark line get included in the BOM. I checked: echo "sparkScalaVersions" | grep -E 'knownSparkVersions|defaultSparkVersions|sparkVersions|spark[0-9]+' exits 1. Could the pattern (and the "Wire the new line" file list below) include it?
| - `settings.gradle`, `spark/build.gradle`, and `jmh.gradle`: register the core, extensions, runtime, and benchmark projects. | ||
| - `.gitignore`: cover generated benchmark or warehouse paths for the new tree. | ||
| - `.github/workflows/spark-ci.yml` and `.github/workflows/cve-scan.yml`: add supported combinations while respecting the current matrix-size and JDK/Scala exclusions. | ||
| - `dev/stage-binaries.sh` and snapshot publication workflows: add the line only when artifacts should be published. Preview source support and release publication are separate decisions. |
There was a problem hiding this comment.
This section separates preview support from release publication decisions, which is the right distinction, but nothing here or in the discovery command above mentions .gitattributes. The export-ignore entries there are what actually gate whether a preview version tree is included in git archive source releases. #18024, "Include Spark 4.2 in source releases," was entirely about removing /spark/v4.2 and /spark/v4.2/** from .gitattributes. Could this get called out explicitly, and could .gitattributes be added to the discovery search paths in "Establish the target"?
|
Thanks @manuzhang. Generally, this looks like a useful skill but It's worth a quick dev@ thread before this comes out of draft, so the directory choice isn't decided by default? |
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions. |
Include the BOM Scala registry and source archive rules when adding a Spark line so both release integration points are considered. Generated-by: Codex
About this PR
Adds a repo-local, agent-neutral skill for introducing support for a new Spark minor version in Iceberg.
The skill generalizes the Spark 4.2 preview workflow and documents how to:
Testing
quick_validate.py .agents/skills/add-spark-versiongit diff --check upstream/main...HEADAI Disclosure