Skip to content

Flink 2.1: Remove flink-metrics-dropwizard from runtime #16093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amogh-jahagirdar merged 2 commits into from
Apr 26, 2026
Merged

Flink 2.1: Remove flink-metrics-dropwizard from runtime #16093

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c053ac7
Flink 2.1: Remove flink-metrics-dropwizard from runtime.
rdblue Apr 23, 2026
8092571
Flink 2.1: Update runtime-deps.txt.
rdblue Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions flink/v2.1/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,9 +169,6 @@ project(":iceberg-flink:iceberg-flink-runtime-${flinkMajorVersion}") {
exclude group: 'com.google.code.findbugs', module: 'jsr305'
}

// for dropwizard histogram metrics implementation
implementation libs.flink21.metrics.dropwizard

@mxm mxm Apr 27, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out, we have this as a compileOnly dependency as well (see here) and in in fact use Dropwizard Histograms. Flink does not ship this dependency by default, see https://github.com/apache/flink/blob/73d71d9db0854c7e15b8232eacf605034d22dfbf/flink-dist/pom.xml#L282.

While this is an optional dependency, removing this would also remove histogram metrics. Peter and I agreed that we should continue to ship this dependency in the fat jar.

Re-adding here: #16126


// for integration testing with the flink-runtime-jar
// all of those dependencies are required because the integration test extends FlinkTestBase
integrationCompileOnly project(':iceberg-api')
Expand Down
2 changes: 0 additions & 2 deletions flink/v2.1/flink-runtime/runtime-deps.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,9 @@ com.github.luben:zstd-jni:1.5.7-3
com.google.errorprone:error_prone_annotations:2.10.0
dev.failsafe:failsafe:3.3.2
io.airlift:aircompressor:2.0.3
io.dropwizard.metrics:metrics-core:3.2.6
org.apache.avro:avro:1.12.1
org.apache.datasketches:datasketches-java:6.2.0
org.apache.datasketches:datasketches-memory:3.0.2
org.apache.flink:flink-metrics-dropwizard:2.1.0
org.apache.httpcomponents.client5:httpclient5:5.6
org.apache.httpcomponents.core5:httpcore5-h2:5.4
org.apache.httpcomponents.core5:httpcore5:5.4
Expand Down
Loading