Skip to content

perf(manifest): upgrade to apache-avro 0.22 and read manifest entries without Value #3354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
laskoviymishka merged 5 commits into from
Oct 9, 2026
Merged

perf(manifest): upgrade to apache-avro 0.22 and read manifest entries without Value #3354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a80adde
perf(manifest): upgrade to apache-avro 0.22 and read manifest entries…
mbutrovich Oct 5, 2026
969b7cd
add test cases, update docs
mbutrovich Oct 5, 2026
9148688
address PR feedback
mbutrovich Oct 6, 2026
fefcbd6
address PR feedback.
mbutrovich Oct 7, 2026
95667f5
address PR feedback
mbutrovich Oct 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
116 changes: 98 additions & 18 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ unused_qualifications = "deny"
[workspace.dependencies]
aes-gcm = "0.10"
anyhow = "1.0.72"
apache-avro = { version = "0.21", features = ["snappy", "zstandard"] }
apache-avro = { version = "0.22", features = ["snappy", "zstandard"] }

@laskoviymishka laskoviymishka Oct 6, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The deserializer's union handling rides on how 0.22's deserialize_any dispatches unions, which isn't a documented public contract — a 0.22.x minor bump could shift it under us. Worth a comment here that the adapter semantics are pinned to this version, and keeping test_parse_manifest_reads_union_writer_fields_as_{required,optional} as the guard for the next bump.

@mbutrovich mbutrovich Oct 6, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The deserializer's union handling rides on how 0.22's deserialize_any dispatches unions, which isn't a documented public contract

As I read serde's Deserializer contract, deserialize_any on a self-describing format dispatches on the data. 0.22's schema-aware deserialize_any reads a union's branch index and continues with that branch's schema (deser_schema/mod.rs#L228-L272). The new tests in avro/deserializer.rs read union and non-union writer values into plain and Option targets. A 0.22.x release that changes the dispatch fails them, along with the two union tests you named. Would those tests work as the guard instead of a comment in Cargo.toml?

array-init = "2"
arrow = "59.2"
arrow-arith = "59.2"
Expand Down
1 change: 1 addition & 0 deletions crates/iceberg/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ rand = { workspace = true }
regex = { workspace = true }
serde_arrow = { version = "0.14", features = ["arrow-59"] }
tempfile = { workspace = true }
tracing-subscriber = { workspace = true }

[package.metadata.cargo-machete]
# These dependencies are added to ensure minimal dependency version
Expand Down
Loading
Loading