Skip to content

fix: raise when binding starts-with with an out-of-range literal #4144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Shahzeb-DataEngineer wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: raise when binding starts-with with an out-of-range literal #4144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pyiceberg/expressions/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -915,11 +915,15 @@ def bind(self, schema: Schema, case_sensitive: bool = True) -> BoundLiteralPredi
return AlwaysTrue()
elif isinstance(self, (GreaterThan, GreaterThanOrEqual, EqualTo)):
return AlwaysFalse()
else:
raise ValueError(f"Cannot bind {type(self).__name__} with AboveMax literal")
elif isinstance(lit, BelowMin):
if isinstance(self, (GreaterThan, GreaterThanOrEqual, NotEqualTo)):
return AlwaysTrue()
elif isinstance(self, (LessThan, LessThanOrEqual, EqualTo)):
return AlwaysFalse()
else:
raise ValueError(f"Cannot bind {type(self).__name__} with BelowMin literal")

return self.as_bound(bound_term, lit) # type: ignore

Expand Down
14 changes: 14 additions & 0 deletions tests/expressions/test_expressions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,6 +295,20 @@ def test_empty_bind_not_in(table_schema_simple: Schema) -> None:
assert bound == AlwaysTrue()


@pytest.mark.parametrize(
"expression, match",
[
(StartsWith("bar", "2147483648"), "AboveMax"),
(NotStartsWith("bar", "2147483648"), "AboveMax"),
(StartsWith("bar", "-2147483649"), "BelowMin"),
(NotStartsWith("bar", "-2147483649"), "BelowMin"),
],
)
def test_bind_starts_with_out_of_range_literal(table_schema_simple: Schema, expression: BooleanExpression, match: str) -> None:
with pytest.raises(ValueError, match=match):
expression.bind(table_schema_simple)


def test_bind_not_in_equal_term(table_schema_simple: Schema) -> None:
bound = BoundNotIn(
BoundReference(table_schema_simple.find_field(1), table_schema_simple.accessor_for_field(1)), {literal("hello")}
Expand Down
Loading