Repository navigation
Conversation
timestamp-micros is handled by an explicit branch in _convert_logical_type that also honors adjust-to-utc, so the mapping entry was never used.
rambleraptor
approved these changes
Oct 22, 2026
rambleraptor
left a comment
Collaborator
There was a problem hiding this comment.
This looks great as a one-liner.
It looks like we need to have that same area in the code handle some of the other time related types (timestamp-millis and time-millis), but let's keep that to a follow-up
ebyhr
approved these changes
Oct 23, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
timestamp-microsis handled by an explicit branch in _convert_logical_type`:iceberg-python/pyiceberg/utils/schema_conversion.py
Lines 379 to 383 in d37149c
That also honors adjust-to-utc, so the mapping entry was never used.
Are these changes tested?
Are there any user-facing changes?