Repository navigation
ci: standardize RustFS setup across Iceberg repos - #2056
Merged
kevinjqliu merged 2 commits intoOct 20, 2026
Merged
Conversation
The rustfs/rustfs:1.0.0 image sets RUSTFS_VOLUMES=/data and its entrypoint uses it when no arguments are given, so `command: ["/data"]` restates the image default. This aligns the object-store service with the canonical RustFS setup shared across Apache Iceberg repos. Generated-by: GitHub Copilot Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
kevinjqliu
marked this pull request as draft
September 25, 2026 04:17
Member
|
@kevinjqliu this looks good and CI (including both integration suites) is green — can you mark it ready for review so I can merge it? |
Use the latest stable rustfs/rustfs image and turn off the unused web console with RUSTFS_CONSOLE_ENABLE=false, dropping the 9001 port mapping. This matches the RustFS setup shared across Iceberg repos. Generated-by: GitHub Copilot Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
kevinjqliu
changed the title
kevinjqliu
commented
Oct 20, 2026
| - RUSTFS_SECRET_KEY=password | ||
| - RUSTFS_SERVER_DOMAINS=object-store | ||
| - RUSTFS_OBS_LOG_STDOUT_ENABLED=true | ||
| - RUSTFS_CONSOLE_ENABLE=false |
Contributor
Author
There was a problem hiding this comment.
removes console port 9001, we dont need it
| ports: | ||
| - 9001:9001 | ||
| - 9000:9000 | ||
| command: ["/data"] |
Contributor
Author
There was a problem hiding this comment.
this is the default, can remove
kevinjqliu
marked this pull request as ready for review
October 20, 2026 18:20
zeroshade
approved these changes
Oct 20, 2026
zeroshade
left a comment
zeroshade
left a comment
Member
There was a problem hiding this comment.
Looks good: 1.0.3 with the /health/ready healthcheck, stdout logs on, and the console off with port 9001 gone (nothing in the repo uses it). Dropping command: ["/data"] relies on the image default, and both integration suites starting the stack confirm that, along with curl still being present for the healthcheck. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #2055 and apache/iceberg#18246. Standardizes the RustFS setup across the Iceberg repos. Same change in:
The setup:
rustfs/rustfs:1.0.3, the latest stable./health/ready./healthis just liveness and can pass before storage and IAM are ready, so bucket creation can race it.RUSTFS_OBS_LOG_STDOUT_ENABLED=true. Otherwisedocker logsis empty.RUSTFS_CONSOLE_ENABLE=falseand no port 9001. Nothing uses the console.command: ["/data"]goes too.Ran
docker compose configand startedrustfs/rustfs:1.0.3with the new config:/health/readyreturns 200 and logs show up indocker logs.AI disclosure: Assisted by GitHub Copilot.