Skip to content

feat(docker): add HEALTHCHECK and remove unused cron from Dockerfiles #3052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bitflicker64 wants to merge 5 commits into
base: master
Choose a base branch
from
+17 −5
Open

feat(docker): add HEALTHCHECK and remove unused cron from Dockerfiles #3052

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a21a6c0
feat(docker): add HEALTHCHECK and remove unused cron from Dockerfiles
bitflicker64 Jun 5, 2026
027e3b7
ci(docker): verify HEALTHCHECK is present in built images
bitflicker64 Jun 5, 2026
b8984c8
feat(docker): add HEALTHCHECK and remove cron from Dockerfile-hstore
bitflicker64 Jun 5, 2026
9b3f6c4
fix(docker): remove kill-0 fallback from HEALTHCHECK — HTTP-only
bitflicker64 Jun 7, 2026
f6f7c14
fix(docker): remove kill-0 fallback from Dockerfile-hstore HEALTHCHECK
bitflicker64 Jun 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/docker-build-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,4 +45,8 @@ jobs:

- name: Build ${{ matrix.dockerfile }}
run: |
docker build -f ${{ matrix.dockerfile }} .
IMAGE_ID=$(docker build -q -f ${{ matrix.dockerfile }} .)
echo "Built: $IMAGE_ID"
HC=$(docker inspect --format='{{json .Config.Healthcheck}}' "$IMAGE_ID")
echo "Healthcheck: $HC"
[[ "$HC" != "null" ]] || { echo "ERROR: HEALTHCHECK missing in ${{ matrix.dockerfile }}"; exit 1; }
4 changes: 3 additions & 1 deletion hugegraph-pd/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ RUN apt-get -q update \
curl \
lsof \
vim \
cron \
&& apt-get clean \
&& rm -rf /var/lib/apt/lists/*

Expand All @@ -63,5 +62,8 @@ RUN chmod 755 ./docker-entrypoint.sh
EXPOSE 8620
VOLUME /hugegraph-pd

HEALTHCHECK --interval=15s --timeout=10s --start-period=90s --retries=3 \
CMD curl -fsS http://localhost:8620/v1/health >/dev/null

ENTRYPOINT ["/usr/bin/dumb-init", "--"]
CMD ["./docker-entrypoint.sh"]
4 changes: 3 additions & 1 deletion hugegraph-server/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ RUN apt-get -q update \
curl \
lsof \
vim \
cron \
&& apt-get clean \
&& rm -rf /var/lib/apt/lists/* \
&& sed -i "s/^restserver.url.*$/restserver.url=http:\/\/0.0.0.0:8080/g" ./conf/rest-server.properties
Expand All @@ -67,5 +66,8 @@ RUN chmod 755 ./docker-entrypoint.sh
EXPOSE 8080
VOLUME /hugegraph-server

HEALTHCHECK --interval=15s --timeout=10s --start-period=90s --retries=3 \
CMD curl -fsS http://localhost:8080/versions >/dev/null

ENTRYPOINT ["/usr/bin/dumb-init", "--"]
CMD ["./docker-entrypoint.sh"]
4 changes: 3 additions & 1 deletion hugegraph-server/Dockerfile-hstore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ RUN apt-get -q update \
curl \
lsof \
vim \
cron \
&& apt-get clean \
&& rm -rf /var/lib/apt/lists/* \
&& sed -i "s/^restserver.url.*$/restserver.url=http:\/\/0.0.0.0:8080/g" ./conf/rest-server.properties
Expand All @@ -69,5 +68,8 @@ RUN chmod 755 ./docker-entrypoint.sh
EXPOSE 8080
VOLUME /hugegraph-server

HEALTHCHECK --interval=15s --timeout=10s --start-period=90s --retries=3 \
CMD curl -fsS http://localhost:8080/versions >/dev/null

ENTRYPOINT ["/usr/bin/dumb-init", "--"]
CMD ["./docker-entrypoint.sh"]
4 changes: 3 additions & 1 deletion hugegraph-store/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ RUN apt-get -q update \
curl \
lsof \
vim \
cron \
&& apt-get clean \
&& rm -rf /var/lib/apt/lists/*

Expand All @@ -63,5 +62,8 @@ RUN chmod 755 ./docker-entrypoint.sh
EXPOSE 8520
VOLUME /hugegraph-store

HEALTHCHECK --interval=15s --timeout=10s --start-period=90s --retries=3 \
CMD curl -fsS http://localhost:8520/v1/health >/dev/null

ENTRYPOINT ["/usr/bin/dumb-init", "--"]
CMD ["./docker-entrypoint.sh"]
Loading