feat(serializer) : make buffer max capacity configurable#3049
Open
LegendPei wants to merge 3 commits into
Open
feat(serializer) : make buffer max capacity configurable#3049LegendPei wants to merge 3 commits into
LegendPei wants to merge 3 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3049 +/- ##
=============================================
+ Coverage 36.08% 93.25% +57.17%
+ Complexity 338 65 -273
=============================================
Files 803 9 -794
Lines 68227 267 -67960
Branches 8963 22 -8941
=============================================
- Hits 24617 249 -24368
+ Misses 40963 8 -40955
+ Partials 2647 10 -2637 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
imbajin
reviewed
Jun 5, 2026
Member
imbajin
left a comment
There was a problem hiding this comment.
The implementation is close and the process-wide scope is the right fit for BytesBuffer. Please avoid last-opened-graph-wins behavior by making that process-wide semantic explicit and rejecting conflicting graph configs.
bitflicker64
added a commit
to bitflicker64/incubator-hugegraph
that referenced
this pull request
Jun 7, 2026
tail --pid does not forward signals to the supervised process. Add a TERM/INT trap that sends SIGTERM to Java and polls with kill -0 until Java exits cleanly before the entrypoint exits. Addresses review feedback from imbajin on apache#3049.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the PR
This PR makes the max capacity of one serializer buffer configurable instead of always using the hardcoded default 128MB limit.
The default behavior remains unchanged, while users who need to serialize larger objects can tune the buffer limit through configuration. The new option is still bounded to avoid unbounded memory allocation.
Main Changes
Does this PR potentially affect the following parts?
Documentation Status
Doc - TODODoc - DoneDoc - No Need