Skip to content

Raise a clear error for unknown TypedDict fields in extract_fields #1733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
breken-ai wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −0
Open

Raise a clear error for unknown TypedDict fields in extract_fields #1733

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions hamilton/function_modifiers/expanders.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -768,6 +768,7 @@ def _determine_fields_to_extract(
for field in fields:
if field not in typed_dict_fields:
errors.append(f"{field} is not a field in the `TypedDict` {output_type}.")
continue
reduced_fields[field] = typed_dict_fields[field]
fields = reduced_fields
elif isinstance(fields, dict):
Expand Down
1 change: 1 addition & 0 deletions tests/function_modifiers/test_expanders.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,6 +396,7 @@ def function() -> return_type: # type: ignore
("np.ndarray", {"A": int}),
("pd.DataFrame", {"A": int}),
("MyDictBad", {"A": int}),
("MyDict", (["test", "not_a_field"])),
("MyDictInheritanceBadCase", {"A": SomeObject}),
("dict", ("A", "B")),
("dict", (["A", "B"])),
Expand Down