[GOBBLIN-2197] Replace use of org.codehaus.jackson with org.fasterxml.jackson#4104
[GOBBLIN-2197] Replace use of org.codehaus.jackson with org.fasterxml.jackson#4104Blazer-007 wants to merge 1 commit into
Conversation
| "jacksonCore": "org.codehaus.jackson:jackson-core-asl:1.9.13", | ||
| "jacksonMapperAsl": "org.codehaus.jackson:jackson-mapper-asl:1.9.13", | ||
| "jacksonCore": "org.fasterxml.jackson:jackson-core-asl:2.18.0", | ||
| "jacksonMapperAsl": "org.fasterxml.jackson:jackson-mapper-asl:2.18.0", |
There was a problem hiding this comment.
@Blazer-007 this doesn't look right
should be
com.fasterxml.jackson.core:jackson-core:2.18.9
com.fasterxml.jackson.core:jackson-databind:2.18.9
2.18.9 was released today with more security fixes
There was a problem hiding this comment.
Would suggest that you remove jacksonMapperAsl and use jacksonMapper below while fixing the version number to be newer, eg 2.18.9
| import org.codehaus.jackson.JsonFactory; | ||
| import org.codehaus.jackson.map.ObjectMapper; | ||
| import org.fasterxml.jackson.JsonFactory; | ||
| import org.fasterxml.jackson.map.ObjectMapper; |
There was a problem hiding this comment.
this is wrong - should be com.fasterxml.jackson.databind.ObjectMapper and com.fasterxml.jackson.core.JsonFactory
|
all the class imports seem incorrect - they should all start com.fasterxml.jackson but here are subpackages. You can lookup the classes in https://javadoc.io/doc/com.fasterxml.jackson.core/jackson-core/2.18.9/index.html and https://javadoc.io/doc/com.fasterxml.jackson.core/jackson-databind/2.18.9/index.html |
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
Description
Replace use of org.codehaus.jackson with org.fasterxml.jackson
Tests
Commits