Skip to content

[GOBBLIN-2197] Replace use of org.codehaus.jackson with org.fasterxml.jackson#4104

Open
Blazer-007 wants to merge 1 commit into
apache:masterfrom
Blazer-007:update_codehaus
Open

[GOBBLIN-2197] Replace use of org.codehaus.jackson with org.fasterxml.jackson#4104
Blazer-007 wants to merge 1 commit into
apache:masterfrom
Blazer-007:update_codehaus

Conversation

@Blazer-007

Copy link
Copy Markdown
Member

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots (if applicable):
    Replace use of org.codehaus.jackson with org.fasterxml.jackson

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@pjfanning

Copy link
Copy Markdown
Member

"jacksonCore": "org.codehaus.jackson:jackson-core-asl:1.9.13",
"jacksonMapperAsl": "org.codehaus.jackson:jackson-mapper-asl:1.9.13",
"jacksonCore": "org.fasterxml.jackson:jackson-core-asl:2.18.0",
"jacksonMapperAsl": "org.fasterxml.jackson:jackson-mapper-asl:2.18.0",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Blazer-007 this doesn't look right

should be

com.fasterxml.jackson.core:jackson-core:2.18.9
com.fasterxml.jackson.core:jackson-databind:2.18.9

2.18.9 was released today with more security fixes

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would suggest that you remove jacksonMapperAsl and use jacksonMapper below while fixing the version number to be newer, eg 2.18.9

import org.codehaus.jackson.JsonFactory;
import org.codehaus.jackson.map.ObjectMapper;
import org.fasterxml.jackson.JsonFactory;
import org.fasterxml.jackson.map.ObjectMapper;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is wrong - should be com.fasterxml.jackson.databind.ObjectMapper and com.fasterxml.jackson.core.JsonFactory

@pjfanning

Copy link
Copy Markdown
Member

all the class imports seem incorrect - they should all start com.fasterxml.jackson but here are subpackages.

You can lookup the classes in https://javadoc.io/doc/com.fasterxml.jackson.core/jackson-core/2.18.9/index.html and https://javadoc.io/doc/com.fasterxml.jackson.core/jackson-databind/2.18.9/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants