Skip to content

[GLUTEN][CI] Download MinIO binaries from GitHub releases instead of dl.min.io - #13012

Merged
jackylee-ch merged 1 commit into
apache:mainfrom
LuciferYang:ci-fix-minio-download
Sep 14, 2026
Merged

jackylee-ch merged 1 commit into
apache:mainfrom
LuciferYang:ci-fix-minio-download

Conversation

@LuciferYang

Copy link
Copy Markdown
Contributor

What changes are proposed in this pull request?

install_minio in .github/workflows/util/install-spark-deps.sh downloads the MinIO server and client from dl.min.io, and both URLs now return HTTP 410 Gone: MinIO has taken its community binaries off that host. -f makes curl exit non-zero and set -e fails the step, so every job that calls install_minio (tpc-test-ubuntu and the celeborn / uniffle / OOM / random-kill jobs, all in velox_backend_x86.yml) fails at MinIO install regardless of the change under test.

This pulls the pinned release assets from GitHub instead. minio/minio's latest release ships no assets, so the server is pinned to the last release that still carries them:

  • server RELEASE.2025-09-07T16-13-09Z
  • client RELEASE.2025-08-13T08-35-41Z

Same event that broke Paimon CI (apache/paimon#9780), different surface: Paimon pulls minio/minio as a Docker image through testcontainers and requalified it to quay.io/minio/minio, but Gluten runs minio server and mc as standalone binaries, so it is the binary endpoint rather than an image name that needs to change. linux-amd64 is unchanged, matching the one x86 workflow that uses these helpers.

How was this patch tested?

bash -n on the script. Both asset URLs were downloaded directly: the server asset is a valid 110 MB x86-64 ELF binary and the client asset serves anonymously. Full coverage is the CI run on this PR, which is where install_minio and setup_minio actually execute.

Was this patch authored or co-authored using generative AI tooling?

Generated-by: Claude claude-opus-5

Related issue: #13011

Copilot AI lite review requested due to automatic review settings September 14, 2026 01:07
@github-actions github-actions Bot added the INFRA label Sep 14, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No unresolved review issues were identified.

Pull request overview

Updates CI MinIO installation to download pinned server and client binaries from GitHub releases instead of unavailable dl.min.io endpoints.

Changes:

  • Pins MinIO server and client release versions.
  • Downloads Linux amd64 assets from GitHub releases.
File summaries
File Summary
.github/workflows/util/install-spark-deps.sh Replaces obsolete MinIO URLs with pinned GitHub release assets.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@jackylee-ch jackylee-ch left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jackylee-ch
jackylee-ch merged commit 6ade09d into apache:main Sep 14, 2026
3 checks passed
@LuciferYang

Copy link
Copy Markdown
Contributor Author

Thank you @jackylee-ch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants