[GLUTEN][CI] Download MinIO binaries from GitHub releases instead of dl.min.io - #13012
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues were identified.
Pull request overview
Updates CI MinIO installation to download pinned server and client binaries from GitHub releases instead of unavailable dl.min.io endpoints.
Changes:
- Pins MinIO server and client release versions.
- Downloads Linux amd64 assets from GitHub releases.
File summaries
| File | Summary |
|---|---|
.github/workflows/util/install-spark-deps.sh |
Replaces obsolete MinIO URLs with pinned GitHub release assets. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Author
|
Thank you @jackylee-ch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
install_minioin.github/workflows/util/install-spark-deps.shdownloads the MinIO server and client fromdl.min.io, and both URLs now return HTTP 410 Gone: MinIO has taken its community binaries off that host.-fmakes curl exit non-zero andset -efails the step, so every job that callsinstall_minio(tpc-test-ubuntuand the celeborn / uniffle / OOM / random-kill jobs, all invelox_backend_x86.yml) fails at MinIO install regardless of the change under test.This pulls the pinned release assets from GitHub instead.
minio/minio's latest release ships no assets, so the server is pinned to the last release that still carries them:RELEASE.2025-09-07T16-13-09ZRELEASE.2025-08-13T08-35-41ZSame event that broke Paimon CI (apache/paimon#9780), different surface: Paimon pulls
minio/minioas a Docker image through testcontainers and requalified it toquay.io/minio/minio, but Gluten runsminio serverandmcas standalone binaries, so it is the binary endpoint rather than an image name that needs to change.linux-amd64is unchanged, matching the one x86 workflow that uses these helpers.How was this patch tested?
bash -non the script. Both asset URLs were downloaded directly: the server asset is a valid 110 MB x86-64 ELF binary and the client asset serves anonymously. Full coverage is the CI run on this PR, which is whereinstall_minioandsetup_minioactually execute.Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude claude-opus-5
Related issue: #13011