[python] Python bindings - add log filter pushdown - #4127
Open
fresh-borzoni wants to merge 1 commit into
Open
Conversation
fresh-borzoni
force-pushed
the
python-filter-pushdown
branch
2 times, most recently
from
August 27, 2026 13:57
1bedda6 to
231dc48
Compare
fresh-borzoni
force-pushed
the
python-filter-pushdown
branch
from
August 27, 2026 14:36
231dc48 to
a535ab9
Compare
Member
Author
fresh-borzoni
changed the title
leekeiabstraction
left a comment
leekeiabstraction
left a comment
Contributor
There was a problem hiding this comment.
Ty for the PR. Left an early question. Only a third of the way through atm. Will continue tmr
| } | ||
| } | ||
|
|
||
| fn __and__(&self, other: &Predicate) -> Predicate { |
Contributor
There was a problem hiding this comment.
Curious why there are two flavours of and/or functions?
Member
Author
There was a problem hiding this comment.
& and | are the primary form, since and/or are keywords and can't be overloaded. The named ones just mirror .and() in the Rust client and .And() in C++, the way polars pairs Expr.and_() with &.
We can leave one form, just felt it's more intuitive this way :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #4128
Adds filter pushdown to the Python client, catching up with the Rust client and the C++ bindings