[gateway] Add the schema-aware batch write endpoint with per-row outcomes - #4126
Merged
Conversation
beryllw
marked this pull request as draft
August 27, 2026 13:03
beryllw
force-pushed
the
gateway/records-write
branch
from
August 27, 2026 16:15
0fe98a7 to
26f4007
Compare
beryllw
marked this pull request as ready for review
August 27, 2026 16:16
beryllw
force-pushed
the
gateway/records-write
branch
from
August 27, 2026 16:24
26f4007 to
cfd9761
Compare
fresh-borzoni
left a comment
fresh-borzoni
left a comment
Member
There was a problem hiding this comment.
@beryllw Thank you for the PR, left some minor comments, PTAL
| let error = match tokio::time::timeout_at(deadline.into(), future).await { | ||
| Ok(Ok(())) => continue, | ||
| Ok(Err(error)) => classify_unknown(error), | ||
| Err(_) => GatewayError::new(ErrorKind::DeadlineExceeded, UNKNOWN_COMPLETION), |
Member
There was a problem hiding this comment.
A write to a dropped table waits out the whole deadline and ends up here, so the caller gets timeout and "a retry may duplicate this row" while nothing was written though. Can we surface table_not_found?
Contributor
Author
There was a problem hiding this comment.
fluss-rust currently retries UnknownTableOrBucketException until the deadline, so I filed #4136 and added a TODO here to surface table_not_found once the client returns a definitive dropped-table error. WDYT？
Contributor
Author
|
@naivedogger cc |
fresh-borzoni
approved these changes
Aug 28, 2026
fresh-borzoni
left a comment
fresh-borzoni
left a comment
Member
There was a problem hiding this comment.
@beryllw Thank you for the PR, LGTM 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #4084
Brief change log
Tests
API and Format
Documentation