[flink] Fix batch fallback generating mixed split types for primary-key tables#3296
Open
matrixsparse wants to merge 1 commit intoapache:mainfrom
Open
[flink] Fix batch fallback generating mixed split types for primary-key tables#3296matrixsparse wants to merge 1 commit intoapache:mainfrom
matrixsparse wants to merge 1 commit intoapache:mainfrom
Conversation
matrixsparse
force-pushed
the
feature/fix-batch-fallback-mixed-splits
branch
from
09b5acd to
7ac1f8c
Compare
Contributor
Author
|
Hi @luoyuxia, this is a follow-up fix for the mixed split types issue you mentioned in #3208. Could you PTAL? Thanks! cc @fresh-borzoni |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up fix for #3208.
For primary-key tables in batch mode, when no lake snapshot exists, the previous fallback logic called
initPartitionedSplits()/initNonPartitionedSplits(), which internally invokesgetSnapshotAndLogSplits(). This method may produce mixed split types —HybridSnapshotLogSplitfor buckets with KV snapshots andLogSplitfor buckets without — which the Flink connector does not support merging in batch mode.This fix replaces the fallback path with
initLogTablePartitionSplits()/getLogSplit()to generate uniformLogSplitfor all buckets, avoiding the mixed split type issue.Changes
initPartitionedSplits()→initLogTablePartitionSplits()initNonPartitionedSplits()→getLogSplit(null, null)