[runtime] Fix prune state corner cases around checkpoints#649
Merged
xintongsong merged 1 commit intoMay 12, 2026
Conversation
907b979 to
4372bad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of change
This PR backports #603 to
release-0.2.ActionExecutionOperatorhad two prune-state boundary issues around checkpoints.prune bookkeeping used
messageSequenceNumber, which tracks the latest started sequence, not the latest completed sequence. That means an in-flight sequence could be treated as prune-safe.the operator called
pruneStateas soon as a run completed, before that completion was covered by a completed checkpoint.Both issues are operator-side prune-boundary problems. In the current Kafka backend,
pruneStateonly evicts the in-memory cache, so the correctness impact is mostly masked by replay/rebuild from the durable log. Still, the operator should not rely on that backend detail: the state-store prune boundary should only include completed sequences that are part of a completed checkpoint.On
release-0.2, the backport also needs a small test-file adjustment so the cherry-picked regression helpers compile against the older branch state.Fix
This change makes pruning checkpoint-safe again.
lastCompletedSequenceNumberkeyed statelastCompletedSequenceNumberinstead ofmessageSequenceNumbernotifyCheckpointCompleteTests
The updated tests cover:
API
No
Documentation
doc-neededdoc-not-neededdoc-included