[feature] Enable EventLog display in WebUI by default#638
Merged
Conversation
github-actions
Bot
added
doc-included
Collaborator
Author
|
Hi, @Sxnan and @wenjin272 . Could you please review this PR? Thank you! |
Collaborator
|
Hi, @GreatEugenius. Overall looks good to me, I left some minor comments about details. Additionally, after #609 is merged, I think you may need to make further adjustments. |
Collaborator
Author
Understood, I will rebase to the main branch after #609 is merged. |
wenjin272
reviewed
Apr 27, 2026
GreatEugenius
force-pushed
the
event-log-ui
branch
3 times, most recently
from
348dfc5 to
db15740
Compare
Collaborator
Author
|
Hi @wenjin272, I have addressed all your comments. Please review it again. |
GreatEugenius
force-pushed
the
event-log-ui
branch
from
db15740 to
17b9e9e
Compare
GreatEugenius
force-pushed
the
event-log-ui
branch
2 times, most recently
from
7218f96 to
84fa697
Compare
Collaborator
Author
|
Hi @wenjin272, I have addressed all your comments and rebased to the main branch, which includes the merged pull request #609. Please take a look. |
wenjin272
reviewed
May 12, 2026
GreatEugenius
force-pushed
the
event-log-ui
branch
from
84fa697 to
4d062da
Compare
Collaborator
Author
|
Hi @wenjin272, I have addressed all your comments. Please review it again. |
GreatEugenius
force-pushed
the
event-log-ui
branch
2 times, most recently
from
f6dda96 to
2edd594
Compare
Previously, the EventRouter passed baseLogDir and prettyPrint to the EventLoggerConfig as separate top-level properties, while the agent config map (already used for per-event-type log levels and STANDARD-level truncation limits) carried the same values. The duplication forced loggers to read each setting from a different location and made it easy to drift if one path were updated without the other. This change makes the agent config map the single source of truth: - Promote AGENT_CONFIG_PROPERTY_KEY from FileEventLogger to EventLoggerConfig so any logger (built-in or custom) can share it without depending on the runtime module. - FileEventLogger reads baseLogDir, prettyPrint, event-log.level and event-log.standard.max-* all from the same agentConfig map. - EventRouter only sets AGENT_CONFIG_PROPERTY_KEY; the redundant baseLogDir/prettyPrint properties are dropped. - Update FileEventLoggerTest with a buildConfig helper that seeds baseLogDir; update ActionExecutionOperatorTest to look inside the agent-config map for verification.
wenjin272
reviewed
May 13, 2026
GreatEugenius
force-pushed
the
event-log-ui
branch
from
2edd594 to
bb3d19d
Compare
GreatEugenius
force-pushed
the
event-log-ui
branch
from
bb3d19d to
52e7a6c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue: #252
Purpose of change
Enable EventLog display in WebUI by default.
Tests
UT and local end-to-end testing in the Flink Standalone Cluster:
API
No
Documentation
doc-neededdoc-not-neededdoc-included