FINERACT-2525: Accept MariaDB snapshot isolation conflict responses in savings integration tests#5763
Open
udayagiri-sivasai-dev wants to merge 1 commit intoapache:developfrom
Open
Conversation
Contributor
|
Please sign your commits as described in the CONTRIBUTING.md signing guide. |
2e2001f to
659a44f
Compare
… savings integration tests
659a44f to
36ead12
Compare
| assertTrue( | ||
| SC_OK == statusCode1 | ||
| || SC_CONFLICT == statusCode1 | ||
| || (SC_FORBIDDEN == statusCode1 && msg1.contains("Record has changed since last read")), |
Contributor
There was a problem hiding this comment.
Matching on Record has changed since last read is fragile - if database changes the error message text in a future version, these tests will break again. If the exception were classified as SomeConcurrencyException(not sure, need to check what the actual exception being thrown is) at the ErrorHandler level instead, it would map to 409, and the tests would just work since they already accept SC_CONFLICT.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
How I tested