FINERACT-2586: add fail on duplicate explicit operationIds#5762
Open
San-43 wants to merge 1 commit intoapache:developfrom
Open
FINERACT-2586: add fail on duplicate explicit operationIds#5762San-43 wants to merge 1 commit intoapache:developfrom
San-43 wants to merge 1 commit intoapache:developfrom
Conversation
San-43
changed the title
San-43
changed the title
San-43
force-pushed
the
FINERACT-2586-Add-fail-on-duplicate-explicit-IDs
branch
from
93813cb to
db6c9d5
Compare
San-43
force-pushed
the
FINERACT-2586-Add-fail-on-duplicate-explicit-IDs
branch
from
db6c9d5 to
798a85c
Compare
Contributor
Author
|
Not related. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a small validation step to catch duplicate explicit OpenAPI
operationIdsbefore the spec is generated. FINERACT-2586NOTE: After wiring the validator and running it, it immediately failed on a duplicate
operationId:retrieveWorkingCapitalLoanTemplate, which was declared in:WorkingCapitalLoanApiResourceWorkingCapitalLoanTransactionsApiResourceAfter fixing that one and rebased onto latest develop, it also found another duplicate:
getDelinquencyRangeScheduleTagHistoryByIdBoth of these were added very recently, so this is a good example of why it helps to validate this at OpenAPI generation time instead of finding out later when the generated client or docs start behaving weird.