FINERACT-1185: Add anniversary interest posting period types#5761
Open
SamaSVM wants to merge 1 commit intoapache:developfrom
Open
FINERACT-1185: Add anniversary interest posting period types#5761SamaSVM wants to merge 1 commit intoapache:developfrom
SamaSVM wants to merge 1 commit intoapache:developfrom
Conversation
|
|
||
| @Test | ||
| void retrieveInterestPostingPeriodTypeOptions_shouldIncludeAllAnniversaryTypes() { | ||
| Collection<EnumOptionData> options = service.retrieveInterestPostingPeriodTypeOptions(); |
Contributor
There was a problem hiding this comment.
You may see a lot of Collection usage throughout the Fineract codebase, that's legacy code. Whenever possible, these should be rewritten to use more specific types like List or Set
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added four new SavingsPostingInterestPeriodType values that post interest on the same day of the month as the account opening date (the "anniversary" date).
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.