Skip to content

FINERACT-1185: Add anniversary interest posting period types#5761

Open
SamaSVM wants to merge 1 commit intoapache:developfrom
SamaSVM:FINERACT-1185/anniversary-interest-posting
Open

FINERACT-1185: Add anniversary interest posting period types#5761
SamaSVM wants to merge 1 commit intoapache:developfrom
SamaSVM:FINERACT-1185/anniversary-interest-posting

Conversation

@SamaSVM
Copy link
Copy Markdown
Contributor

@SamaSVM SamaSVM commented Apr 10, 2026

Description

Added four new SavingsPostingInterestPeriodType values that post interest on the same day of the month as the account opening date (the "anniversary" date).

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.


@Test
void retrieveInterestPostingPeriodTypeOptions_shouldIncludeAllAnniversaryTypes() {
Collection<EnumOptionData> options = service.retrieveInterestPostingPeriodTypeOptions();
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may see a lot of Collection usage throughout the Fineract codebase, that's legacy code. Whenever possible, these should be rewritten to use more specific types like List or Set

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants