Repository navigation
minor: set default pooling back to retaining - #20542
Merged
Merged
Conversation
FrankChen021
reviewed
Oct 9, 2026
FrankChen021
left a comment
Member
There was a problem hiding this comment.
🟢 Approval recommended
No actionable issues found in this review. Both HTTP client configuration entry points now default to retaining pooling, and the initialization path passes that selection explicitly to the resource pool. The documentation and configuration tests match the new default while preserving the explicit adaptive override.
Reviewed 4 of 4 changed files, with additional inspection of HTTP client wiring, pool lifecycle and concurrency behavior, and existing pool tests. Assessment is based on static inspection; tests were not run.
This is an automated review by Codex GPT-5.6-Luna(max)
cryptoe
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turned out that the adaptive pooling (added in #20273) may help other issues to surface ; like #20522 (more detail about that is in #20475).
it would probably be safer to switch it off before it gets shipped in a release until we know its safe to turn it back on by default.