Skip to content

minor: set default pooling back to retaining - #20542

Merged
cryptoe merged 1 commit into
apache:masterfrom
kgyrtkirk:disable-adaptive
Oct 9, 2026
Merged

cryptoe merged 1 commit into
apache:masterfrom
kgyrtkirk:disable-adaptive

Conversation

@kgyrtkirk

@kgyrtkirk kgyrtkirk commented Oct 9, 2026 •

Copy link
Copy Markdown
Member

It turned out that the adaptive pooling (added in #20273) may help other issues to surface ; like #20522 (more detail about that is in #20475).

it would probably be safer to switch it off before it gets shipped in a release until we know its safe to turn it back on by default.

@FrankChen021 FrankChen021 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No actionable issues found in this review. Both HTTP client configuration entry points now default to retaining pooling, and the initialization path passes that selection explicitly to the resource pool. The documentation and configuration tests match the new default while preserving the explicit adaptive override.

Reviewed 4 of 4 changed files, with additional inspection of HTTP client wiring, pool lifecycle and concurrency behavior, and existing pool tests. Assessment is based on static inspection; tests were not run.


This is an automated review by Codex GPT-5.6-Luna(max)

@cryptoe
cryptoe merged commit efa1513 into apache:master Oct 9, 2026
27 of 28 checks passed
@github-actions github-actions Bot added this to the 39.0.0 milestone Oct 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants