Skip to content

test: fix flaky ScheduledExecutorsTest.testscheduleWithFixedDelay #20526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FrankChen021 merged 2 commits into from
Oct 9, 2026
Merged

test: fix flaky ScheduledExecutorsTest.testscheduleWithFixedDelay #20526

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7b1971
test: fix flaky ScheduledExecutorsTest.testscheduleWithFixedDelay
ykisana Oct 8, 2026
4873d91
fix comment punctuation
ykisana Oct 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions ...ng/src/test/java/org/apache/druid/java/util/common/concurrent/ScheduledExecutorsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,15 +44,15 @@ public void testscheduleWithFixedDelay() throws Exception
List<Long> taskStartTimes = new ArrayList<>();
AtomicInteger executionCount = new AtomicInteger(0);
CountDownLatch latch = new CountDownLatch(1);
long startTime = System.currentTimeMillis();
final long startTime = System.nanoTime();

ScheduledExecutors.scheduleWithFixedDelay(
exec,
initialDelay,
delay,
() -> {
try {
long taskStart = System.currentTimeMillis();
final long taskStart = TimeUnit.NANOSECONDS.toMillis(System.nanoTime() - startTime);
int count = executionCount.getAndIncrement();
synchronized (taskStartTimes) {
taskStartTimes.add(taskStart);
Expand All @@ -78,10 +78,11 @@ public void testscheduleWithFixedDelay() throws Exception
Assertions.assertTrue(completed, "Should complete within timeout");
Assertions.assertEquals(4, executionCount.get(), "Should have exactly 4 executions");

// Verify first task starts at approximately the initial delay, in real life this is greater than 100ms due to overhead.
long firstTaskStart = taskStartTimes.get(0) - startTime;
// Verify first task starts at approximately the initial delay.
// It can fire exactly on time, so the 100ms lower bound is inclusive.
final long firstTaskStart = taskStartTimes.get(0);
Assertions.assertTrue(
firstTaskStart > 100 && firstTaskStart < 500,
firstTaskStart >= 100 && firstTaskStart < 500,
"First task should start at approximately initial delay (100ms), was: " + firstTaskStart
);

Expand Down
Loading