Repository navigation
Conversation
fetchAllUsedSegmentsWithOvershadowedStatus hands out a ResourceHolder that closes the streamed response; MetadataSegmentView and SystemSchema close it, also on early exit, and QueryHandler now closes the bound Interpreter so scans under Filter/Project nodes are released too. No segment left behind.
FrankChen021
left a comment
There was a problem hiding this comment.
🟢 Approval recommended
No actionable issues found. The response holder closes both the lazy JSON iterator and its underlying input stream, including when closed before the first read. Metadata polling closes the holder on successful and failed iteration, uncached scans carry ownership through datasource filtering, and sys.segments propagates early close through its enumerable. The bound interpreter is released on completion, early exit, and enumeration failure.
Reviewed 12 of 12 changed files, including production changes, regression tests, benchmark and embedded-client adaptations, plus relevant callers, sequence cleanup, and Calcite 1.42.0 iterator/interpreter implementations.
Validation: git diff --check 3e93651 aff397e passed. Static review only; tests and builds were not run.
This is an automated review by Codex GPT-5.6-Luna(max)
note: recommend to enable ignore whitespace while viewing the changes
needs #202521 to be present for a test which is failing right now to pass