Repository navigation
[enhancement](lance) Add cache diagnostics and BE runtime index selection #69625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Gabriel39
wants to merge
4
commits into
apache:branch-4.2
Choose a base branch
from
Gabriel39:dev/lance-cache-profile-index-selection-4.2
base: branch-4.2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+425
−106
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
db0cbc2
[enhancement](lance) Add cache diagnostics and scalar index auto sele…
Gabriel39 a4e757b
Move Lance scalar index cost selection to BE runtime
Gabriel39 f1d1441
[chore](build) Use merged upstream lance-c runtime selection
Gabriel39 501aa25
[fix](regression) Account for Lance runtime scan choices
Gabriel39 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P2] Publish Session counters before the final profile is frozen
For a remote Lance scan with concurrent readers and an early
LIMIT, one worker can satisfy the limit while another, whose dataset is already open, is still blocked inlance_scanner_next.stop_scanners()requests stopping without joining that worker, which retains itsScannerDelegate; dropping the local state's delegates therefore does not run this dataset-close collection yet. Meanwhile, pipeline task completion callsPipelineFragmentContext::_close_fragment_instance(), which saves an independentTRuntimeProfileTreeinQueryContext. When the worker eventually returns and closes its dataset, these counter updates arrive after that final copy and never reach the saved profile. The completed query consequently loses that reader's observation window, leaving the new miss counters unavailable or partial despite successful statistics access. Publish an available snapshot before final profile serialization, with synchronization and delta accounting so later close does not double count, and cover early LIMIT with a second worker held in a native read. The current test explicitly closes the reader before inspecting its profile and misses this path.