Skip to content

[chore](build) Raise threadpool header reach baseline to 1200 #69607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shuke987 merged 1 commit into from
Oct 26, 2026
Merged

[chore](build) Raise threadpool header reach baseline to 1200 #69607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build-support/check-header-deps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -587,7 +587,7 @@
"gen_cpp/Types_types.h": 1993,
"gen_cpp/segment_v2.pb.h": 1234,
"gen_cpp/PaloInternalService_types.h": 1133,
"util/threadpool.h": 988,
"util/threadpool.h": 1200,
# parsed_page.h holds RleDecoder<bool> by value and constructs it in the
# header, so the whole storage read stack sees the RLE machinery; a live
# dependency, budgeted as-is (trimming it is a refactor, not a gate).
Expand Down
10 changes: 10 additions & 0 deletions build-support/tests/test-build-hygiene-header-deps.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,16 @@ echo "${OUT}" | grep -q -- "--reach runtime/workload_group/workload_group.h" \
|| fail "reverse budget failure lacks the --reach fix pointer"
cp "${BACKUP}/be/src/util/pretty_printer.h" "${ROOT}/be/src/util/pretty_printer.h"

# ---- RED: threadpool reach remains bounded after its baseline increase ----
printf '#include "util/threadpool.h"\n' >> "${ROOT}/be/src/common/logging.h"
OUT="$(run_gate)"; EC=$?
[ "${EC}" -eq 1 ] || fail "threadpool reach injection expected exit 1, got ${EC}"
echo "${OUT}" | grep -q "util/threadpool.h now reaches" \
|| fail "threadpool reverse budget breach not reported"
echo "${OUT}" | grep -q -- "--reach util/threadpool.h" \
|| fail "threadpool reach failure lacks the --reach fix pointer"
cp "${BACKUP}/be/src/common/logging.h" "${ROOT}/be/src/common/logging.h"

# ---- RED: pch whitelist (quoted include added to pch.h) ----
printf '#include "common/logging.h"\n' >> "${ROOT}/be/src/pch/pch.h"
OUT="$(run_gate)"; EC=$?
Expand Down
Loading