Repository navigation
fix(linker): handle empty pr issue regexp - #8911
Closed
matan-wonderful wants to merge 1 commit into
Closed
matan-wonderful wants to merge 1 commit into
matan-wonderful wants to merge 1 commit into
Conversation
Signed-off-by: Matan Ryngler <matan.r@wonderful.ai>
matan-wonderful
force-pushed
the
fix/linker-empty-pr-regexp
branch
from
June 8, 2026 08:25
96d5911 to
e0fdd84
Compare
Contributor
|
This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs. |
Contributor
|
This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a linker crash when
prToIssueRegexpis empty.Normal-mode projects can enable the linker metric without a configured regexp, which currently produces a linker task with an empty regexp.
PrepareTaskDataleavesPrToIssueRegexpnil in that case, andLinkPrToIssuelater panics when it callsFindAllStringon the nil regexp.Changes:
prToIssueRegexpis empty.prToIssueRegexp.LinkPrToIssue.Does this close any open issues?
No linked issue.
Screenshots
Not applicable.
Other Information
Validation:
go test ./plugins/linker/tasks ./plugins/linker/implfrombackend/git diff --check