Repository navigation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(kll): add weighted update #293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
feat(kll): add weighted update #293
Changes from all commits
3486e33File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This silently accepts a zero weight, while both references reject it: datasketches-java
KllItemsSketch.update(item, weight)throwsWeight is less than one., and the companion cpp PR #542 throwsweight must be positive. FollowingCountMinSketch::update_with_weightis defensible, but please record the divergence here so callers porting from Java or C++ are not surprised by the silent success. I verified the Rust branches and the level folding against both references; only this case differs.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
weight == self.capacity - self.num_retainedcannot compact either, sinceinternal_updatechecksnum_retained >= capacitybefore pushing. With<, that boundary takes the merge path and drops out of exact mode for no reason: at k=200, 150updatecalls plusupdate_with_weight(x, 50)keep 153 retained items in estimation mode, while 50updatecalls keep all 200.<=costs nothing; if you prefer parity with Java and cpp, a comment saying so would help.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test never reaches the branch it looks like it covers: weights
1..=15total 120 against a capacity of 200, so every call takes theO(weight)fast path and the merge path is untested here. Adding the boundary case (150 updates, thenupdate_with_weight(x, 50)) would cover the guard insketch.rsand pin the one weight where the choice changes the sketch's mode.