Repository navigation
CI: use the generate_java_files profile in the SerDe workflow - #583
Merged
Merged
Conversation
datasketches-java renamed the profile from generate-java-files to generate_java_files. Maven only warns about a profile that does not exist, so the Java files were not generated, and the copy step has failed on every push to master since 2026-08-31. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Coverage Report for CI Build 43963465059Coverage remained the same at 96.865%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Java SerDe Compatibility Test has failed on every push to master since Aug 31. datasketches-java names its profile
generate_java_files, but the workflow still asks forgenerate-java-files. Maven only warns that the profile doesn't exist, so the Java tests pass but no.skfiles are written, and the copy step then fails. The C++SERDE_COMPATtests have not run in CI since then.This changes the profile name to
generate_java_files. In datasketches-java, all test profile, TestNG group and POM property names use underscores.I ran the workflow's steps locally with datasketches-java main (fe31572): the profile wrote 289 files, and all 32
[serde_compat]test cases pass, along with the rest of the tests, built withSERDE_COMPAT=true.🤖 Generated with Claude Code