Skip to content

CI: use the generate_java_files profile in the SerDe workflow - #583

Merged
proost merged 1 commit into
masterfrom
fix-serde-compat-profile
Nov 17, 2026
Merged

proost merged 1 commit into
masterfrom
fix-serde-compat-profile

Conversation

@leerho

@leerho leerho commented Nov 16, 2026

Copy link
Copy Markdown
Member

The Java SerDe Compatibility Test has failed on every push to master since Aug 31. datasketches-java names its profile generate_java_files, but the workflow still asks for generate-java-files. Maven only warns that the profile doesn't exist, so the Java tests pass but no .sk files are written, and the copy step then fails. The C++ SERDE_COMPAT tests have not run in CI since then.

This changes the profile name to generate_java_files. In datasketches-java, all test profile, TestNG group and POM property names use underscores.

I ran the workflow's steps locally with datasketches-java main (fe31572): the profile wrote 289 files, and all 32 [serde_compat] test cases pass, along with the rest of the tests, built with SERDE_COMPAT=true.

🤖 Generated with Claude Code

datasketches-java renamed the profile from generate-java-files to
generate_java_files. Maven only warns about a profile that does not
exist, so the Java files were not generated, and the copy step has
failed on every push to master since 2026-08-31.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 43963465059

Coverage remained the same at 96.865%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 16844
Covered Lines: 16316
Line Coverage: 96.87%
Coverage Strength: 1646008.7 hits per line

💛 - Coveralls

@proost proost left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@proost
proost merged commit 70bcf6f into master Nov 17, 2026
35 checks passed
@proost
proost deleted the fix-serde-compat-profile branch November 17, 2026 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants