Repository navigation
fix: preserve hash join dynamic filters across recursive CTE iterations - #26669
Open
Kristofferjoha wants to merge 4 commits into
Open
Kristofferjoha wants to merge 4 commits into
Kristofferjoha wants to merge 4 commits into
Conversation
github-actions
Bot
added
physical-expr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #26641.
Rationale for this change
Hash joins inside recursive CTEs read every probe-side row on each iteration because their dynamic filters stop updating the scan. This prevents pruning during recursive queries such as graph walks.
What changes are included in this PR?
Depends on #26056 for
DynamicFilterPhysicalExpr::reset(). It hasnt been merged yet, however it has been approved, so i tought i was safe to use its implementation.What is the testing strategy for this PR?
The new cte.slt case checks that the recursive query returns 1–5 and that the probe scan outputs 4 rows and prunes 396 rows across four iterations.
Are there any user-facing changes?
The public
HashJoinExecBuilder::reset_statemethod now returnsResult<Self>;callers must handle the result.