[branch-55] fix(common): support empty struct in ScalarValue::compact and new_default (#24582) - #24876
Merged
Merged
Conversation
…ault (apache#24582) ## Which issue does this PR close? Closes apache#24581. ## Rationale for this change `StructArray::new` panics for structs with zero fields because it cannot infer array length from an empty column list. This hit two code paths in `ScalarValue`: `new_default` when building a default value for a zero-field struct type, and `compact_view_buffers` (used by `ScalarValue::compact`) when compacting a struct array that has zero fields but a nonzero row count. ## What changes are included in this PR? - `ScalarValue::new_default` and `compact_view_buffers` now special-case zero-field structs, using `StructArray::new_empty_fields` (which takes an explicit length/nulls instead of inferring it from columns) rather than `StructArray::new`. - Added `test_compact_empty_struct` covering the panic case. ## Are these changes tested? Yes, new unit test added. ## Are there any user-facing changes? No behavior change other than fixing a panic on empty-field structs.
25 tasks
Member
Author
|
@unikdahal as the original author could you please review the back port? |
Jefffrey
approved these changes
Sep 2, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## branch-55 #24876 +/- ##
==========================================
Coverage 81.19% 81.19%
==========================================
Files 1110 1110
Lines 387713 387773 +60
Branches 387713 387773 +60
==========================================
+ Hits 314785 314841 +56
- Misses 54412 54413 +1
- Partials 18516 18519 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
unikdahal
approved these changes
Sep 2, 2026
unikdahal
left a comment
unikdahal
left a comment
Contributor
There was a problem hiding this comment.
Thanks @timsaucer LGTM
Member
Author
|
Thank you @Jefffrey and @unikdahal |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a back port of #24582 into
branch-55for inclusion in 55.1.0. Please see the original PR for details.