fix: check for key retriever in Parquet decryption properties conversion - #24866
Open
adamreeve wants to merge 1 commit into
Open
fix: check for key retriever in Parquet decryption properties conversion#24866adamreeve wants to merge 1 commit into
adamreeve wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #24866 +/- ##
==========================================
- Coverage 81.61% 81.61% -0.01%
==========================================
Files 1123 1123
Lines 409392 409398 +6
Branches 409392 409398 +6
==========================================
- Hits 334143 334124 -19
- Misses 55630 55652 +22
- Partials 19619 19622 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
adamreeve
marked this pull request as ready for review
September 2, 2026 00:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Previously an error when retrieving the footer key was used as an indication that a key retriever was used, but this isn't reliable. A key retriever implementation might choose to return a footer key even if no key metadata is provided. This could mean that a footer key is set in the converted decryption properties but column keys are not correctly converted.
arrow-rs didn't previously expose whether a key retriever is used, but this was added in 59.0.0.
What changes are included in this PR?
Use the new
FileDecryptionProperties::uses_key_retrieverto determine whetherFileDecryptionPropertiesuses a key retriever, rather than rely on getting an error when getting the footer key.What is the testing strategy for this PR?
Updated existing unit test.
Are there any user-facing changes?
No, this changes an error message but should otherwise not affect users except if they had a key retriever implementation that would return footer keys without any metadata being provided.