Support planning scalar functions in ExprPlanner - #24846
Open
MichaelScofield wants to merge 1 commit into
Open
Conversation
Add RawScalarExpr and route resolved scalar function calls through registered expression planners before constructing ScalarFunction.
Contributor
Author
|
@alamb PTAL |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #24846 +/- ##
========================================
Coverage 81.58% 81.58%
========================================
Files 1123 1123
Lines 406610 406748 +138
Branches 406610 406748 +138
========================================
+ Hits 331716 331852 +136
+ Misses 55457 55454 -3
- Partials 19437 19442 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@jayzhan211 PTAL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
ExprPlanneras well? #21270.Rationale for this change
ExprPlannersupports customizing aggregate and window function planning, but scalar functions bypass registered expression planners.This prevents downstream users from customizing scalar function expressions during SQL planning.
What changes are included in this PR?
RawScalarExprto represent a scalar function before final expression construction.ExprPlanner::plan_scalar.What is the testing strategy for this PR?
A SQL planner integration test registers a custom scalar function planner that rewrites the semantically equivalent single-argument expression
coalesce(42)to42.The resulting logical plan verifies that the custom planner handled the scalar function.
Are there any user-facing changes?
Yes. This PR adds the public
RawScalarExprtype and theExprPlanner::plan_scalarextension point.The new trait method has a default implementation, so existing
ExprPlannerimplementations remain compatible.