Repository navigation
PostgreSQL: Parse ROUTINE and ALL PROCEDURES | ROUTINES IN SCHEMA grant targets - #2761
Open
LucaCappelletti94 wants to merge 1 commit into
Open
LucaCappelletti94 wants to merge 1 commit into
LucaCappelletti94 wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2761 +/- ##
=======================================
Coverage 82.48% 82.49%
=======================================
Files 42 42
Lines 35469 35495 +26
Branches 35469 35495 +26
=======================================
+ Hits 29258 29282 +24
Misses 2675 2675
- Partials 3536 3538 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
LucaCappelletti94
force-pushed
the
upstream/grant-routine
branch
from
October 29, 2026 12:29
690ce6a to
a9a1160
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PostgreSQL's
GRANTandREVOKEtakeON ROUTINEwith the same signature list asON FUNCTIONandON PROCEDURE, and cover a whole schema withON ALL PROCEDURES IN SCHEMAandON ALL ROUTINES IN SCHEMA(https://www.postgresql.org/docs/current/sql-grant.html). None of the three parsed.GRANT EXECUTE ON ROUTINE f(int) TO bobfailed withExpected: TO, found: f, andGRANT EXECUTE ON ALL ROUTINES IN SCHEMA s TO bobwithExpected: TO, found: ROUTINES.GrantObjectsgainsRoutines,AllProceduresInSchemaandAllRoutinesInSchema, next to theFunctionsandProceduresvariants from #2727. A routine can be a function or a procedure, so each form keeps its own variant and prints back as written.